Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false pos. dict-iter-missing-items for tuple keys #4939

Merged

Conversation

DanielNoord
Copy link
Collaborator

@DanielNoord DanielNoord commented Aug 31, 2021

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
🐛 Bug fix

Description

This fixes a false positive emitted for dictionaries that contain only
tuples as keys. This makes unpacking the dictionary without calling .items() valid.
This closes #3283

This fixes a false positive emitted for dictionaries that contain only
tuples as keys. This makes unpacking the dictionary without calling
`.items()` valid.
This closes pylint-dev#3283
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Aug 31, 2021
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.11.0 milestone Aug 31, 2021
@Pierre-Sassoulas Pierre-Sassoulas merged commit 6cd8193 into pylint-dev:main Aug 31, 2021
@DanielNoord DanielNoord deleted the dict-iter-missing-items-fix branch August 31, 2021 13:20
@coveralls
Copy link

coveralls commented Aug 31, 2021

Pull Request Test Coverage Report for Build 1185893559

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.786%

Totals Coverage Status
Change from base Build 1185750414: 0.001%
Covered Lines: 13570
Relevant Lines: 14625

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dict-iter-missing-items does not recognize tuple keys
3 participants